Completed OS support for clamav-milter#48
Open
ubellavance wants to merge 4 commits intoedestecd:masterfrom
Open
Completed OS support for clamav-milter#48ubellavance wants to merge 4 commits intoedestecd:masterfrom
ubellavance wants to merge 4 commits intoedestecd:masterfrom
Conversation
Author
|
There are puppet-lint errors, but I think they're false positives. Can you have a look at it @edestecd? Thanks, |
Author
Owner
|
@ubellavance Can you fix the lint errors? Many of them are about quoted booleans. Just remove the quotes from false and true. |
Owner
|
The other lint errors are about indent. You need to take away two spaces. |
Author
|
All fixed @edestecd, Travis tests passing! |
Owner
|
needs a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Ubuntu 12.04, 14.04, 16.04; RHEL6 derivatives.
Fixes #32.